gh-122988: Clarify that types.get_original_bases() ignores inherited __orig_bases__ - #156917
Open
owenthcarey wants to merge 1 commit into
Open
gh-122988: Clarify that types.get_original_bases() ignores inherited __orig_bases__#156917owenthcarey wants to merge 1 commit into
owenthcarey wants to merge 1 commit into
Conversation
…rited __orig_bases__
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs for
types.get_original_bases()say that for classes that have an__orig_bases__attribute, the function returnscls.__orig_bases__. That reads as if the function is equivalent to attribute access, but the implementation only looks incls.__dict__. A class whose base defines__orig_bases__will inherit the attribute, whileget_original_bases()correctly falls back tocls.__bases__for it.This rewords the paragraph to say the lookup is on the class's own namespace and that inherited attributes are ignored, and adds a short example of that case to the existing examples block.
Fixes #122988
get_original_basesdoes not return whatcls.__orig_bases__returns #122988